Shortened ?loo_subsample title and slightly edited description#339
Merged
jgabry merged 3 commits intostan-dev:masterfrom Mar 20, 2026
Merged
Shortened ?loo_subsample title and slightly edited description#339jgabry merged 3 commits intostan-dev:masterfrom
jgabry merged 3 commits intostan-dev:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 31 31
Lines 2992 2992
=======================================
Hits 2776 2776
Misses 216 216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jgabry
requested changes
Mar 19, 2026
Member
jgabry
left a comment
jgabry
left a comment
There was a problem hiding this comment.
Thank you! I agree about simplifying the title. I made one comment with a suggested change.
R/loo_subsample.R
Outdated
| @@ -1,5 +1,7 @@ | |||
| #' Efficient approximate leave-one-out cross-validation (LOO) using subsampling, | |||
| #' so that less costly and more approximate computation is made for all LOO-fold, | |||
| #' @title Efficient approximate LOO-CV | |||
Member
There was a problem hiding this comment.
You don't need @title if the text is in the first line of the roxygen comment block (it will automatically use @title for you).
Also, I think we should keep "using subsampling" in the title since that's what distinguishes loo_subsample, but I agree we should get rid of the rest of the long title and put that info in the description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338
Note that:
devtools::check(vignettes = F)